Author Topic: Filter by Button Count  (Read 7585 times)

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Filter by Button Count
« on: January 29, 2018, 03:51:06 AM »
I would like to filter by button count. Apparently, this feature was added here. I am having trouble getting this to work.

Here’s some small snippets.

Emulator config:
Code: [Select]
import_extras        /Applications/mame0192b_macOS/catver.ini;/Applications/mame0192b_macOS/controls.ini;/Applications/mame0192b_macOS/nplayers.ini
romlist:
Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
2020bb;2020 Super Baseball (set 1);neogeo;;1991;SNK / Pallas;Sports / Baseball;2P sim;0;joystick (8-way),joystick (8-way);good;1;raster;neogeo;;;

I have tried generating full romlist and there is no difference. controls.ini is the latest version 0.141.1. However, the commit says „- Now parses button count from mame -listxml output and allows filtering based on buttons“ so I assume it wouldn’t even need controls.ini file.

Anyone have any ideas of things to try? Or is this feature broken? I have the all killer no filler tag list ready to push to github, but want to make sure it can actually be filtered within attract mode, else I have to create separate lists for people with different amounts of buttons. :-[

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #1 on: January 29, 2018, 02:50:18 PM »
You don't need controls.ini and it isn't supported even if you have it. Manually create your mame.xml outside of AM and then reference it in your emulator mame.cfg and regenerate the romlist.

Code: [Select]
import_extras        .\extras\mame.xml



If I use
Code: [Select]
info_source          listxml
to generate the romlist instead of the steps above I don't get the button information in the mame.txt romlist.

I hope this helps.

BTW - This is on Windows with AM 2.3.
« Last Edit: January 29, 2018, 02:51:58 PM by progets »

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #2 on: January 29, 2018, 06:42:00 PM »
I’m developing on mac, haven’t tried it on my arcade machine running windows yet.

Code: [Select]
$ /Applications/mame0192b_macOS/mame64 -listxml > mame.xml
Code: [Select]
# Generated by Attract-Mode v2.3.0-23
#
executable           /Applications/mame0192b_macOS/mame64
args                 [name] -bios unibios32 -video bgfx -bgfx_screen_chains crt-geom-deluxe
rompath              /Applications/mame0192b_macOS/roms/
romext               .zip;.7z;<DIR>
system               neogeo;Neo Geo
info_source          listxml
import_extras        /Applications/mame0192b_macOS/mame.xml;/Applications/mame0192b_macOS/catver.ini
artwork    flyer           
artwork    marquee         /Applications/mame0192b_macOS/minis/
artwork    snap            /Applications/mame0192b_macOS/snap/
artwork    wheel           


Code: [Select]
$ /Applications/Attract.app/Contents/MacOS/attract --build-romlist neogeo --full
No dice. I have tried leaving blank param or even commenting out the whole info_source listxml line from config file. carver.ini is imported. No buttons. What is even more weird is that if I comment out the whole info_source line, and have mame.xml path in the import_extras, lots of missing info is yielded in the romlist.txt file.

Any ideas? I’ll try the arcade machine in the morning to see if its a platform issue.

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #3 on: January 29, 2018, 07:38:38 PM »
I don't know about the AM build on Mac. I do know on Windows that you get different results depending on how you configure the emulator. I do get the button fields populated in the mame.txt romlist when using this config on Windows.

Code: [Select]
executable           D:\Emulators\MAME\mame.exe
args                 [name]
rompath              ..\Roms\MAME\
romext               .zip
system               Arcade
import_extras        .\extras\mame.xml;.\extras\catver.ini;.\extras\nplayers.ini

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #4 on: January 30, 2018, 06:33:52 AM »
I don't know about the AM build on Mac. I do know on Windows that you get different results depending on how you configure the emulator. I do get the button fields populated in the mame.txt romlist when using this config on Windows.

Code: [Select]
executable           D:\Emulators\MAME\mame.exe
args                 [name]
rompath              ..\Roms\MAME\
romext               .zip
system               Arcade
import_extras        .\extras\mame.xml;.\extras\catver.ini;.\extras\nplayers.ini

This is so stupid. I’m using attract 2.3 on windows for my arcade machine, exported mame.xml (which does include button information), remove the ino_source line and added mame.ml to import_extras. Still no dice.

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #5 on: January 30, 2018, 12:11:12 PM »
I don't know about the AM build on Mac. I do know on Windows that you get different results depending on how you configure the emulator. I do get the button fields populated in the mame.txt romlist when using this config on Windows.

Code: [Select]
executable           D:\Emulators\MAME\mame.exe
args                 [name]
rompath              ..\Roms\MAME\
romext               .zip
system               Arcade
import_extras        .\extras\mame.xml;.\extras\catver.ini;.\extras\nplayers.ini

This is so stupid. I’m using attract 2.3 on windows for my arcade machine, exported mame.xml (which does include button information), remove the ino_source line and added mame.ml to import_extras. Still no dice.

When you said this didn't work for you I tested and found out that you are right. My system was built a while back and I forgot that the mame.xml that I used to get the buttons counts was actually one that was modified using the program Romlister. I didn't mean to mislead you, I simply forgot about this step since I did it long ago.

With that being said, I know that it's possible to get the button info into the mame.xml that can be used by AM but I don't know if it can be done directly with MAME and AM alone not using a 3rd party app.

Maybe this helps you and maybe it doesn't but I don't want you to pull your hair out over a step that I forgot to get mine working.

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #6 on: January 30, 2018, 12:23:00 PM »
Thank you progrets for confirming. That is very helpful. I can stop thinking about what I am doing wrong. I’ll update the github issue I opened saying that it’s now verified. Thanks again.

I’ll go ahead and push my tag lists. Should be helpful to anyone with 6 button setups.

qqplayer

  • Sr. Member
  • ****
  • Posts: 301
    • View Profile
Re: Filter by Button Count
« Reply #7 on: January 30, 2018, 12:31:58 PM »
This worked for me:

Code: [Select]
# Generated by Attract-Mode v2.2.1
#
executable           emulators\mame\mame0106b\mame.exe
args                 [name]
rompath              emulators\mame\mame0106b\roms
romext               .zip
system               Arcade
info_source          listxml
import_extras        J:\AM\extras\MAME.xml;J:\AM\extras\Mame\Catver.ini;J:\AM\extras\Mame\controls.ini;J:\AM\extras\Mame\nplayers.ini

I think the "trick" is here:

Code: [Select]
info_source          listxml
Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
88games;'88 Games;MAME (Libretro);;1988;Konami;Sports / Track & Field;4P alt / 2P sim;0;;good;1;raster;;;;3
98best44;'98 NeoPri Best 44 (Neo Print);MAME (Libretro);;1998;SNK;Print Club;???;0;joy8way;preliminary;1;raster;;;;4
yumefuda;(Medal) Yumefuda [BET];MAME (Libretro);;1991;Alba;Tabletop / Hanafuda;1P;0;;good;1;raster;;;;
005;005;MAME (Libretro);;1981;Sega;Maze / Shooter Small;2P alt;270;joy4way;imperfect;1;raster;;;;1
1on1gov;1 on 1 Government (Japan);MAME (Libretro);;2000;Tecmo;Sports / Basketball;2P sim;0;joy8way;imperfect;1;raster;tps;;;3
gtmr;1000 Miglia: Great 1000 Miles Rally (94/07/18);MAME (Libretro);;1994;Kaneko;Driving / Race;2P alt;0;joy8way,dial,paddle;good;1;raster;;;;2
progolf;18 Holes Pro Golf (set 1);MAME (Libretro);;1981;Data East Corporation;Sports / Golf;2P alt;270;joy8way;imperfect;1;raster;;;;1
18wheelr;18 Wheeler (JPN);MAME (Libretro);;2000;Sega;Driving;1P;0;joy8way;preliminary;1;raster;naomi;;;6
1941;1941: Counter Attack (World);MAME (Libretro);;1990;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
pc_1942;1942 (PlayChoice-10);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P alt;0;joy8way;imperfect;2;raster;playch10;;;2
1942;1942 (Revision B);MAME (Libretro);;1984;Capcom;Shooter / Flying Vertical;2P alt;270;joy8way;good;1;raster;;;;2
1943kai;1943 Kai: Midway Kaisen (Japan);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1943;1943: The Battle of Midway (Euro);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1944;1944: The Loop Master (USA 000620);MAME (Libretro);;2000;Eighting / Raizing (Capcom license);Shooter / Flying Vertical;2P sim;0;joy8way;good;1;raster;;;;2
1945kiii;1945k III;MAME (Libretro);;2000;Oriental;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;4
19xx;19XX: The War Against Destiny (USA 951207);MAME (Libretro);;1996;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
openice;2 On 2 Open Ice Challenge (rev 1.21);MAME (Libretro);;1995;Midway;Sports / Hockey;4P sim;0;joy8way;good;1;raster;;;;3
2020bb;2020 Super Baseball (set 1);MAME (Libretro);;1991;SNK / Pallas;Sports / Baseball;2P sim;0;joy8way;good;1;raster;neogeo;;;4
« Last Edit: January 30, 2018, 12:34:31 PM by qqplayer »

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #8 on: January 30, 2018, 12:45:10 PM »
This worked for me:

Code: [Select]
# Generated by Attract-Mode v2.2.1
#
executable           emulators\mame\mame0106b\mame.exe
args                 [name]
rompath              emulators\mame\mame0106b\roms
romext               .zip
system               Arcade
info_source          listxml
import_extras        J:\AM\extras\MAME.xml;J:\AM\extras\Mame\Catver.ini;J:\AM\extras\Mame\controls.ini;J:\AM\extras\Mame\nplayers.ini

I think the "trick" is here:

Code: [Select]
info_source          listxml
Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
88games;'88 Games;MAME (Libretro);;1988;Konami;Sports / Track & Field;4P alt / 2P sim;0;;good;1;raster;;;;3
98best44;'98 NeoPri Best 44 (Neo Print);MAME (Libretro);;1998;SNK;Print Club;???;0;joy8way;preliminary;1;raster;;;;4
yumefuda;(Medal) Yumefuda [BET];MAME (Libretro);;1991;Alba;Tabletop / Hanafuda;1P;0;;good;1;raster;;;;
005;005;MAME (Libretro);;1981;Sega;Maze / Shooter Small;2P alt;270;joy4way;imperfect;1;raster;;;;1
1on1gov;1 on 1 Government (Japan);MAME (Libretro);;2000;Tecmo;Sports / Basketball;2P sim;0;joy8way;imperfect;1;raster;tps;;;3
gtmr;1000 Miglia: Great 1000 Miles Rally (94/07/18);MAME (Libretro);;1994;Kaneko;Driving / Race;2P alt;0;joy8way,dial,paddle;good;1;raster;;;;2
progolf;18 Holes Pro Golf (set 1);MAME (Libretro);;1981;Data East Corporation;Sports / Golf;2P alt;270;joy8way;imperfect;1;raster;;;;1
18wheelr;18 Wheeler (JPN);MAME (Libretro);;2000;Sega;Driving;1P;0;joy8way;preliminary;1;raster;naomi;;;6
1941;1941: Counter Attack (World);MAME (Libretro);;1990;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
pc_1942;1942 (PlayChoice-10);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P alt;0;joy8way;imperfect;2;raster;playch10;;;2
1942;1942 (Revision B);MAME (Libretro);;1984;Capcom;Shooter / Flying Vertical;2P alt;270;joy8way;good;1;raster;;;;2
1943kai;1943 Kai: Midway Kaisen (Japan);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1943;1943: The Battle of Midway (Euro);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1944;1944: The Loop Master (USA 000620);MAME (Libretro);;2000;Eighting / Raizing (Capcom license);Shooter / Flying Vertical;2P sim;0;joy8way;good;1;raster;;;;2
1945kiii;1945k III;MAME (Libretro);;2000;Oriental;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;4
19xx;19XX: The War Against Destiny (USA 951207);MAME (Libretro);;1996;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
openice;2 On 2 Open Ice Challenge (rev 1.21);MAME (Libretro);;1995;Midway;Sports / Hockey;4P sim;0;joy8way;good;1;raster;;;;3
2020bb;2020 Super Baseball (set 1);MAME (Libretro);;1991;SNK / Pallas;Sports / Baseball;2P sim;0;joy8way;good;1;raster;neogeo;;;4

I’ve tried that on windows attract 2.3 and Mac attract 2.3.32. What version did you build romlist with?

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #9 on: January 30, 2018, 12:58:30 PM »
I can tell you with 100% certainty that AM does not support controls.ini. If you define it in the emulator.cfg and try to build a romlist you will see in the console window that it shows that it is not supported. You will also notice that there is no mention of it in the AM ReadMe when it talks about the catver.ini and nplayers.ini files.

Controls.ini can be used with other programs but not directly with AM.

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #10 on: January 30, 2018, 01:07:40 PM »
This worked for me:

Code: [Select]
# Generated by Attract-Mode v2.2.1
#
executable           emulators\mame\mame0106b\mame.exe
args                 [name]
rompath              emulators\mame\mame0106b\roms
romext               .zip
system               Arcade
info_source          listxml
import_extras        J:\AM\extras\MAME.xml;J:\AM\extras\Mame\Catver.ini;J:\AM\extras\Mame\controls.ini;J:\AM\extras\Mame\nplayers.ini

I think the "trick" is here:

Code: [Select]
info_source          listxml
Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
88games;'88 Games;MAME (Libretro);;1988;Konami;Sports / Track & Field;4P alt / 2P sim;0;;good;1;raster;;;;3
98best44;'98 NeoPri Best 44 (Neo Print);MAME (Libretro);;1998;SNK;Print Club;???;0;joy8way;preliminary;1;raster;;;;4
yumefuda;(Medal) Yumefuda [BET];MAME (Libretro);;1991;Alba;Tabletop / Hanafuda;1P;0;;good;1;raster;;;;
005;005;MAME (Libretro);;1981;Sega;Maze / Shooter Small;2P alt;270;joy4way;imperfect;1;raster;;;;1
1on1gov;1 on 1 Government (Japan);MAME (Libretro);;2000;Tecmo;Sports / Basketball;2P sim;0;joy8way;imperfect;1;raster;tps;;;3
gtmr;1000 Miglia: Great 1000 Miles Rally (94/07/18);MAME (Libretro);;1994;Kaneko;Driving / Race;2P alt;0;joy8way,dial,paddle;good;1;raster;;;;2
progolf;18 Holes Pro Golf (set 1);MAME (Libretro);;1981;Data East Corporation;Sports / Golf;2P alt;270;joy8way;imperfect;1;raster;;;;1
18wheelr;18 Wheeler (JPN);MAME (Libretro);;2000;Sega;Driving;1P;0;joy8way;preliminary;1;raster;naomi;;;6
1941;1941: Counter Attack (World);MAME (Libretro);;1990;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
pc_1942;1942 (PlayChoice-10);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P alt;0;joy8way;imperfect;2;raster;playch10;;;2
1942;1942 (Revision B);MAME (Libretro);;1984;Capcom;Shooter / Flying Vertical;2P alt;270;joy8way;good;1;raster;;;;2
1943kai;1943 Kai: Midway Kaisen (Japan);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1943;1943: The Battle of Midway (Euro);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1944;1944: The Loop Master (USA 000620);MAME (Libretro);;2000;Eighting / Raizing (Capcom license);Shooter / Flying Vertical;2P sim;0;joy8way;good;1;raster;;;;2
1945kiii;1945k III;MAME (Libretro);;2000;Oriental;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;4
19xx;19XX: The War Against Destiny (USA 951207);MAME (Libretro);;1996;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
openice;2 On 2 Open Ice Challenge (rev 1.21);MAME (Libretro);;1995;Midway;Sports / Hockey;4P sim;0;joy8way;good;1;raster;;;;3
2020bb;2020 Super Baseball (set 1);MAME (Libretro);;1991;SNK / Pallas;Sports / Baseball;2P sim;0;joy8way;good;1;raster;neogeo;;;4

Why does this config show a mame.exe but the romlists shows MAME (Libretro) as the emulator? This doesn't seem right for a romlist that wasn't modified.

qqplayer

  • Sr. Member
  • ****
  • Posts: 301
    • View Profile
Re: Filter by Button Count
« Reply #11 on: January 30, 2018, 01:24:59 PM »
This worked for me:

Code: [Select]
# Generated by Attract-Mode v2.2.1
#
executable           emulators\mame\mame0106b\mame.exe
args                 [name]
rompath              emulators\mame\mame0106b\roms
romext               .zip
system               Arcade
info_source          listxml
import_extras        J:\AM\extras\MAME.xml;J:\AM\extras\Mame\Catver.ini;J:\AM\extras\Mame\controls.ini;J:\AM\extras\Mame\nplayers.ini

I think the "trick" is here:

Code: [Select]
info_source          listxml
Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
88games;'88 Games;MAME (Libretro);;1988;Konami;Sports / Track & Field;4P alt / 2P sim;0;;good;1;raster;;;;3
98best44;'98 NeoPri Best 44 (Neo Print);MAME (Libretro);;1998;SNK;Print Club;???;0;joy8way;preliminary;1;raster;;;;4
yumefuda;(Medal) Yumefuda [BET];MAME (Libretro);;1991;Alba;Tabletop / Hanafuda;1P;0;;good;1;raster;;;;
005;005;MAME (Libretro);;1981;Sega;Maze / Shooter Small;2P alt;270;joy4way;imperfect;1;raster;;;;1
1on1gov;1 on 1 Government (Japan);MAME (Libretro);;2000;Tecmo;Sports / Basketball;2P sim;0;joy8way;imperfect;1;raster;tps;;;3
gtmr;1000 Miglia: Great 1000 Miles Rally (94/07/18);MAME (Libretro);;1994;Kaneko;Driving / Race;2P alt;0;joy8way,dial,paddle;good;1;raster;;;;2
progolf;18 Holes Pro Golf (set 1);MAME (Libretro);;1981;Data East Corporation;Sports / Golf;2P alt;270;joy8way;imperfect;1;raster;;;;1
18wheelr;18 Wheeler (JPN);MAME (Libretro);;2000;Sega;Driving;1P;0;joy8way;preliminary;1;raster;naomi;;;6
1941;1941: Counter Attack (World);MAME (Libretro);;1990;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
pc_1942;1942 (PlayChoice-10);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P alt;0;joy8way;imperfect;2;raster;playch10;;;2
1942;1942 (Revision B);MAME (Libretro);;1984;Capcom;Shooter / Flying Vertical;2P alt;270;joy8way;good;1;raster;;;;2
1943kai;1943 Kai: Midway Kaisen (Japan);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1943;1943: The Battle of Midway (Euro);MAME (Libretro);;1987;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
1944;1944: The Loop Master (USA 000620);MAME (Libretro);;2000;Eighting / Raizing (Capcom license);Shooter / Flying Vertical;2P sim;0;joy8way;good;1;raster;;;;2
1945kiii;1945k III;MAME (Libretro);;2000;Oriental;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;4
19xx;19XX: The War Against Destiny (USA 951207);MAME (Libretro);;1996;Capcom;Shooter / Flying Vertical;2P sim;270;joy8way;good;1;raster;;;;2
openice;2 On 2 Open Ice Challenge (rev 1.21);MAME (Libretro);;1995;Midway;Sports / Hockey;4P sim;0;joy8way;good;1;raster;;;;3
2020bb;2020 Super Baseball (set 1);MAME (Libretro);;1991;SNK / Pallas;Sports / Baseball;2P sim;0;joy8way;good;1;raster;neogeo;;;4

Why does this config show a mame.exe but the romlists shows MAME (Libretro) as the emulator? This doesn't seem right for a romlist that wasn't modified.

I pasted the wrong txt , this is the mame 106 romlist , sorry.

Code: [Select]
#Name;Title;Emulator;CloneOf;Year;Manufacturer;Category;Players;Rotation;Control;Status;DisplayCount;DisplayType;AltRomname;AltTitle;Extra;Buttons
88games;'88 Games;mame;;1988;Konami;Sports / Track & Field;4;;;good;0;;;;;4
99lstwar;'99: The Last War;mame;sonofphx;1985;Proma;Shooter / Gallery;2;;;good;0;;sonofphx;;;2
99lstwrk;'99: The Last War (Kyugo);mame;sonofphx;1985;Kyugo;Shooter / Gallery;2;;;good;0;;sonofphx;;;2
99lstwra;'99: The Last War (alternate);mame;sonofphx;1985;Proma;Shooter / Gallery;2;;;good;0;;sonofphx;;;2
yumefuda;(Medal) Yumefuda [BET];mame;;;Alba;Tabletop / Hanafuda;1;;;preliminary;0;;;;;6
5;5;mame;;1981;Sega;Maze / Shooter Small;2;;;preliminary;0;;;;;1
yard;10-Yard Fight (Japan);mame;;1983;Irem;;2;;;good;0;;;;;2
gtmra;1000 Miglia: Great 1000 Miles Rally (94/06/13);mame;gtmr;1994;Kaneko;Driving / Race;2;;;good;0;;gtmr;;;2
gtmr;1000 Miglia: Great 1000 Miles Rally (94/07/18);mame;;1994;Kaneko;Driving / Race;2;;;good;0;;;;;2
1941j;1941 - Counter Attack (Japan);mame;1941;1990;Capcom;Shooter / Flying Vertical;2;;;good;0;;1941;;;2
1941;1941 - Counter Attack (World);mame;;1990;Capcom;Shooter / Flying Vertical;2;;;good;0;;;;;2
pc_1942;1942 (PlayChoice-10);mame;;1987;Capcom;Shooter / Flying Vertical;2;;;imperfect;0;;playch10;;;2
1942;1942 (set 1);mame;;1984;Capcom;Shooter / Flying Vertical;2;;;good;0;;;;;2
1942a;1942 (set 2);mame;1942;1984;Capcom;Shooter / Flying Vertical;2;;;good;0;;1942;;;2
1942b;1942 (set 3);mame;1942;1984;Capcom;Shooter / Flying Vertical;2;;;good;0;;1942;;;2
1943kai;1943 Kai: Midway Kaisen (Japan);mame;;1987;Capcom;Shooter / Flying Vertical;2;;;good;0;;;;;2
1943j;1943: Midway Kaisen (Japan);mame;1943;1987;Capcom;Shooter / Flying Vertical;2;;;good;0;;1943;;;2
1943;1943: The Battle of Midway (US);mame;;1987;Capcom;Shooter / Flying Vertical;2;;;good;0;;;;;2
1944j;1944: The Loop Master (Japan 000620);mame;1944;2000;Capcom, supported by Eighting/Raizing;Shooter / Flying Vertical;2;;;preliminary;0;;1944;;;2
1944;1944: The Loop Master (US 000620);mame;;2000;Capcom, supported by Eighting/Raizing;Shooter / Flying Vertical;2;;;good;0;;;;;2
1945kiii;1945k III;mame;;2000;Oriental;Shooter / Flying Vertical;2;;;good;0;;;;;4
19xxa;19XX: The War Against Destiny (Asia 951207);mame;19xx;1996;Capcom;Shooter / Flying Vertical;2;;;good;0;;19xx;;;2
19xxh;19XX: The War Against Destiny (Hispanic 951218);mame;19xx;1996;Capcom;Shooter / Flying Vertical;2;;;good;0;;19xx;;;2
19xxjr1;19XX: The War Against Destiny (Japan 951207);mame;19xx;1996;Capcom;Shooter / Flying Vertical;2;;;good;0;;19xx;;;2
19xxj;19XX: The War Against Destiny (Japan 951225);mame;19xx;1996;Capcom;Shooter / Flying Vertical;2;;;preliminary;0;;19xx;;;2

progets

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1271
    • View Profile
Re: Filter by Button Count
« Reply #12 on: January 30, 2018, 02:00:59 PM »
@qqplayer - That makes sense. I also notice that you're using an older version of MAME.

Seeing the older version of MAME made me look at the actual xml files from an older mame and newer mame and i can see that the buttons are defined differently.

Older MAME
Code: [Select]
<input players="2" buttons="1" coins="2" service="yes">
<control type="joy" ways="4"/>
</input>

Newer MAME (for the same game)
Code: [Select]
<input players="2" coins="2" service="yes">
<control type="joy" player="1" buttons="1" ways="4"/>
<control type="joy" player="2" buttons="1" ways="4"/>
</input>

I can also see that the romlist that qqplayer listed for his 106 mame does include the button count but is missing some of the other controller information due to the changes in the different version of MAME's xml output files.

@keilmillerjr - Vastly different versions of MAME use different xml formats. This seems to be the key for the AM romlist differences.

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #13 on: January 30, 2018, 06:34:32 PM »
@qqplayer - That makes sense. I also notice that you're using an older version of MAME.

Seeing the older version of MAME made me look at the actual xml files from an older mame and newer mame and i can see that the buttons are defined differently.

Older MAME
Code: [Select]
<input players="2" buttons="1" coins="2" service="yes">
<control type="joy" ways="4"/>
</input>

Newer MAME (for the same game)
Code: [Select]
<input players="2" coins="2" service="yes">
<control type="joy" player="1" buttons="1" ways="4"/>
<control type="joy" player="2" buttons="1" ways="4"/>
</input>

I can also see that the romlist that qqplayer listed for his 106 mame does include the button count but is missing some of the other controller information due to the changes in the different version of MAME's xml output files.

@keilmillerjr - Vastly different versions of MAME use different xml formats. This seems to be the key for the AM romlist differences.

Your right. I’m looking at the source code right now and can tell its not matching my xml file. I will try to modify and see if I can get it to work. I believe its ```https://github.com/mickelson/attract/commit/499b85cd24f4ce650cef9aff0f499d61817b18ef#diff-c9a33ae1ce1f2105c0a95fbf1f67edeb``` lines 380-382. No guarantee as its the first time I am dipping into attract source.

Edit: I’m lost in this code. I don’t understand the for loop or why we are comparing the attribute to zero.

keilmillerjr

  • Global Moderator
  • Hero Member
  • *****
  • Posts: 1167
    • View Profile
Re: Filter by Button Count
« Reply #14 on: January 30, 2018, 10:59:47 PM »
Resolved issue and have a pull request! Thank you everyone!

If anyone with an older style mame.xml file, perhaps qqplayer?, wants to either test or send me their older mame.xml file to test - that would be great. It should work for both formats.