SFML-PI updated to 2.5.1

[Oomek]

Hi, I've finally synchronized my SFML-PI 2.5.1 X11 branch with Mickelson's 2.4.0 X11/KMS
Before I create a pull request would you please try it under X11 and KMS on PI3 and PI4 and report any problems here, or on Github?
Thanks.

https://github.com/oomek/sfml-pi

UPDATE:
It has been merged by Andrew on 25/09/2020. Thanks for your tests.

[Oomek]

No one interested?

[progets]

Will this allow AM use on a Pi 4 without X11?

[Oomek]

It's the current Mickelson's master branch updated to 2.5.1 so yes just USE_DRM as before

[walknight]

I can try it under KMS. I'm using rockchip though.
Anything I should pay special attention to?

[Oomek]

Anything unusual.

[tonberryhunter]

Anything unusual.

Could you make an easy to understand guide (with copy pasteable code) on how to update Attract Mode with your build?  Your Github guide doesn't really explain it well.  I'm trying to fix the white border around wheel images and someone pointed me here.   

[Oomek]

What platform you're on? PI3, PI4? What backend GLES, KMS/DRM?

[davisband]

I tried compiling using the instructions here for a raspberry pi 3b+
https://github.com/mickelson/attract/wiki/Compiling-on-the-Raspberry-Pi-(Raspbian-Jessie)

I swapped out this...
git clone --depth 1 https://github.com/mickelson/sfml-pi sfml-pi

with...
git clone --depth 1 https://github.com/oomek/sfml-pi sfml-pi

When everything was done I got a segmentation fault when trying to launch attract.  I am guessing I might of missed a dependency?

[Oomek]

Have you rebuilt Attract Mode?

[davisband]

Yeah, I rebuilt SFML-PI, FFMPEG, and attract mode.  I can try again to make sure I didn't miss something.

Is that correct to just swap out the GIT line for your repo?

[Oomek]

Yes, you just change mickelson to oomek. Just make sure the SFML build folder is empty before rebuilding a new version. You do not need to rebuild ffmpeg

[tonberryhunter]

What platform you're on? PI3, PI4? What backend GLES, KMS/DRM?

The latest Retropie Buster 4.6 image for Pi3.  I installed Attract Mode from source via the Retropie Setup menu.   

[Oomek]

If you could find that update script and if it compiles SFML from source all you need to do is to change the github.com/mickelson/sfml-pi to github.com/oomek/sfml-pi until it gets merged

[davisband]

Just wanted to report back that recompiling (swapping mickelson to oomek) worked great.  It also fixed the border issue on my wheet art.

Thank you!!!